1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-fs-empty-readStream

Browse Source 
Refactor test to remove unnecessary booleans and one unnecesary timer.
Instead, throw Error objects where appropriate and rely on
common.mustCall().

The timer seemed to be the source of an issue when parallelizing tests.

Ref: https://github.com/nodejs/node/pull/4476#issuecomment-168080875
PR-URL: https://github.com/nodejs/node/pull/4490
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2015-12-30 14:02:28 -08:00
parent 4e155e8e2e
commit 44ed9998cf
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/parallel/test-fs-empty-readStream.js
View File

@ -15,15 +15,7 @@ fs.open(emptyFile, 'r', function(error, fd) {
throw new Error('data event should not emit');
});
var readEmit = false;
read.once('end', function() {
readEmit = true;
console.error('end event 1');
});
setTimeout(function() {
assert.equal(readEmit, true);
}, common.platformTimeout(50));
read.once('end', common.mustCall(function endEvent1() {}));
});
fs.open(emptyFile, 'r', function(error, fd) {
@ -36,13 +28,11 @@ fs.open(emptyFile, 'r', function(error, fd) {
throw new Error('data event should not emit');
});
var readEmit = false;
read.once('end', function() {
readEmit = true;
console.error('end event 2');
read.once('end', function endEvent2() {
throw new Error('end event should not emit');
});
setTimeout(function() {
assert.equal(readEmit, false);
assert.equal(read.isPaused(), true);
}, common.platformTimeout(50));
});