1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

process: improve hrtime() error message

Browse Source 
Change error message from the form this format:

  The "time" array must have a length of 2. Received length 0

...to this format:

  The array "time" (length 0) must be of length 2.

PR-URL: https://github.com/nodejs/node/pull/14324
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This commit is contained in:
Rich Trott 2017-07-17 05:15:11 -07:00
parent 7fdcb68dc3
commit 43e105f645
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/internal/errors.js
View File

@ -114,10 +114,9 @@ E('ERR_HTTP_TRAILER_INVALID',
E('ERR_INDEX_OUT_OF_RANGE', 'Index out of range'); E('ERR_INDEX_OUT_OF_RANGE', 'Index out of range');
E('ERR_INVALID_ARG_TYPE', invalidArgType); E('ERR_INVALID_ARG_TYPE', invalidArgType);
E('ERR_INVALID_ARRAY_LENGTH', E('ERR_INVALID_ARRAY_LENGTH',
(name, length, actual) => { (name, len, actual) => {
assert.strictEqual(typeof actual, 'number'); assert.strictEqual(typeof actual, 'number');
return `The "${name}" array must have a length of ${ return `The array "${name}" (length ${actual}) must be of length ${len}.`;
length}. Received length ${actual}`;
}); });
E('ERR_INVALID_BUFFER_SIZE', 'Buffer size must be a multiple of %s'); E('ERR_INVALID_BUFFER_SIZE', 'Buffer size must be a multiple of %s');
E('ERR_INVALID_CALLBACK', 'Callback must be a function'); E('ERR_INVALID_CALLBACK', 'Callback must be a function');

6
test/parallel/test-process-hrtime.js
View File

@ -45,21 +45,21 @@ assert.throws(() => {
}, common.expectsError({ }, common.expectsError({
code: 'ERR_INVALID_ARRAY_LENGTH', code: 'ERR_INVALID_ARRAY_LENGTH',
type: TypeError, type: TypeError,
message: 'The "time" array must have a length of 2. Received length 0' message: 'The array "time" (length 0) must be of length 2.'
})); }));
assert.throws(() => { assert.throws(() => {
process.hrtime([1]); process.hrtime([1]);
}, common.expectsError({ }, common.expectsError({
code: 'ERR_INVALID_ARRAY_LENGTH', code: 'ERR_INVALID_ARRAY_LENGTH',
type: TypeError, type: TypeError,
message: 'The "time" array must have a length of 2. Received length 1' message: 'The array "time" (length 1) must be of length 2.'
})); }));
assert.throws(() => { assert.throws(() => {
process.hrtime([1, 2, 3]); process.hrtime([1, 2, 3]);
}, common.expectsError({ }, common.expectsError({
code: 'ERR_INVALID_ARRAY_LENGTH', code: 'ERR_INVALID_ARRAY_LENGTH',
type: TypeError, type: TypeError,
message: 'The "time" array must have a length of 2. Received length 3' message: 'The array "time" (length 3) must be of length 2.'
})); }));
function validateTuple(tuple) { function validateTuple(tuple) {