1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor event-emitter-remove-all-listeners

Browse Source 
Use common.mustNotCall() to confirm that listener handles never run (as
no events are emitted).

PR-URL: https://github.com/nodejs/node/pull/13165
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2017-05-22 12:14:16 -07:00
parent 16357f2d72
commit 4384f2e2b7
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
test/parallel/test-event-emitter-remove-all-listeners.js
View File

@ -38,24 +38,25 @@ function expect(expected) {
{ {
const ee = new events.EventEmitter(); const ee = new events.EventEmitter();
ee.on('foo', common.noop); const noop = common.mustNotCall();
ee.on('bar', common.noop); ee.on('foo', noop);
ee.on('baz', common.noop); ee.on('bar', noop);
ee.on('baz', common.noop); ee.on('baz', noop);
ee.on('baz', noop);
const fooListeners = ee.listeners('foo'); const fooListeners = ee.listeners('foo');
const barListeners = ee.listeners('bar'); const barListeners = ee.listeners('bar');
const bazListeners = ee.listeners('baz'); const bazListeners = ee.listeners('baz');
ee.on('removeListener', expect(['bar', 'baz', 'baz'])); ee.on('removeListener', expect(['bar', 'baz', 'baz']));
ee.removeAllListeners('bar'); ee.removeAllListeners('bar');
ee.removeAllListeners('baz'); ee.removeAllListeners('baz');
assert.deepStrictEqual(ee.listeners('foo'), [common.noop]); assert.deepStrictEqual(ee.listeners('foo'), [noop]);
assert.deepStrictEqual(ee.listeners('bar'), []); assert.deepStrictEqual(ee.listeners('bar'), []);
assert.deepStrictEqual(ee.listeners('baz'), []); assert.deepStrictEqual(ee.listeners('baz'), []);
// After calling removeAllListeners(), // After calling removeAllListeners(),
// the old listeners array should stay unchanged. // the old listeners array should stay unchanged.
assert.deepStrictEqual(fooListeners, [common.noop]); assert.deepStrictEqual(fooListeners, [noop]);
assert.deepStrictEqual(barListeners, [common.noop]); assert.deepStrictEqual(barListeners, [noop]);
assert.deepStrictEqual(bazListeners, [common.noop, common.noop]); assert.deepStrictEqual(bazListeners, [noop, noop]);
// After calling removeAllListeners(), // After calling removeAllListeners(),
// new listeners arrays is different from the old. // new listeners arrays is different from the old.
assert.notStrictEqual(ee.listeners('bar'), barListeners); assert.notStrictEqual(ee.listeners('bar'), barListeners);
@ -64,8 +65,8 @@ function expect(expected) {
{ {
const ee = new events.EventEmitter(); const ee = new events.EventEmitter();
ee.on('foo', common.noop); ee.on('foo', common.mustNotCall());
ee.on('bar', common.noop); ee.on('bar', common.mustNotCall());
// Expect LIFO order // Expect LIFO order
ee.on('removeListener', expect(['foo', 'bar', 'removeListener'])); ee.on('removeListener', expect(['foo', 'bar', 'removeListener']));
ee.on('removeListener', expect(['foo', 'bar'])); ee.on('removeListener', expect(['foo', 'bar']));
@ -76,7 +77,7 @@ function expect(expected) {
{ {
const ee = new events.EventEmitter(); const ee = new events.EventEmitter();
ee.on('removeListener', common.noop); ee.on('removeListener', common.mustNotCall());
// Check for regression where removeAllListeners() throws when // Check for regression where removeAllListeners() throws when
// there exists a 'removeListener' listener, but there exists // there exists a 'removeListener' listener, but there exists
// no listeners for the provided event type. // no listeners for the provided event type.
@ -89,9 +90,9 @@ function expect(expected) {
ee.on('removeListener', function(name, noop) { ee.on('removeListener', function(name, noop) {
assert.strictEqual(expectLength--, this.listeners('baz').length); assert.strictEqual(expectLength--, this.listeners('baz').length);
}); });
ee.on('baz', common.noop); ee.on('baz', common.mustNotCall());
ee.on('baz', common.noop); ee.on('baz', common.mustNotCall());
ee.on('baz', common.noop); ee.on('baz', common.mustNotCall());
assert.strictEqual(ee.listeners('baz').length, expectLength + 1); assert.strictEqual(ee.listeners('baz').length, expectLength + 1);
ee.removeAllListeners('baz'); ee.removeAllListeners('baz');
assert.strictEqual(ee.listeners('baz').length, 0); assert.strictEqual(ee.listeners('baz').length, 0);