From 43029da762fafabf1d5594b83ee4fbab91dc35d0 Mon Sep 17 00:00:00 2001 From: Kyle Lamse Date: Tue, 18 Jul 2017 14:03:43 -0500 Subject: [PATCH] doc: add note for Windows build path PR-URL: https://github.com/nodejs/node/pull/14354 Fixes: https://github.com/nodejs/node/issues/14337 Reviewed-By: Vse Mozhet Byt Reviewed-By: Refael Ackermann Reviewed-By: Anna Henningsen Reviewed-By: Gibson Fahnestock Reviewed-By: Colin Ihrig --- BUILDING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BUILDING.md b/BUILDING.md index 48a9523c42c..6ab63b25020 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -91,6 +91,8 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and * You may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid popups asking to accept incoming network connections when running tests: +If the path to your build directory contains a space, the build will likely fail. + ```console $ sudo ./tools/macosx-firewall.sh ``` @@ -173,6 +175,8 @@ Prerequisites: [Git for Windows](http://git-scm.com/download/win) includes Git Bash and tools which can be included in the global `PATH`. +If the path to your build directory contains a space, the build will likely fail. + ```console > .\vcbuild ```