1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix incorrect assumptions on uid and gid

Browse Source 
Add a invalidArgTypeErrorCount variable to adjust the number of expected
errors if the uid and gid options cannot be properly validated.

Fixes: https://github.com/nodejs/node/issues/19371
PR-URL: https://github.com/nodejs/node/pull/19554
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit is contained in:
garwahl 2018-03-23 23:24:01 +11:00 committed by Gireesh Punathil
parent 37db277bb4
commit 42c740212d
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-child-process-spawnsync-validation-errors.js
View File

@ -5,13 +5,15 @@ const spawnSync = require('child_process').spawnSync;
const signals = process.binding('constants').os.signals; const signals = process.binding('constants').os.signals;
let invalidArgTypeError; let invalidArgTypeError;
let invalidArgTypeErrorCount = 62;
if (common.isWindows) { if (common.isWindows) {
invalidArgTypeError = invalidArgTypeError =
common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 42); common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 42);
} else { } else {
invalidArgTypeError = invalidArgTypeError =
common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 62); common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError },
invalidArgTypeErrorCount);
} }
const invalidRangeError = const invalidRangeError =
@ -76,6 +78,9 @@ if (!common.isWindows) {
fail('uid', Infinity, invalidArgTypeError); fail('uid', Infinity, invalidArgTypeError);
fail('uid', 3.1, invalidArgTypeError); fail('uid', 3.1, invalidArgTypeError);
fail('uid', -3.1, invalidArgTypeError); fail('uid', -3.1, invalidArgTypeError);
} else {
//Decrement invalidArgTypeErrorCount if validation isn't possible
invalidArgTypeErrorCount -= 10;
} }
} }
@ -95,6 +100,9 @@ if (!common.isWindows) {
fail('gid', Infinity, invalidArgTypeError); fail('gid', Infinity, invalidArgTypeError);
fail('gid', 3.1, invalidArgTypeError); fail('gid', 3.1, invalidArgTypeError);
fail('gid', -3.1, invalidArgTypeError); fail('gid', -3.1, invalidArgTypeError);
} else {
//Decrement invalidArgTypeErrorCount if validation isn't possible
invalidArgTypeErrorCount -= 10;
} }
} }
} }