1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor the code in test-child-process-spawn-loop.js

Browse Source 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10605
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
sivaprasanna 2017-01-04 13:03:20 +05:30 committed by James M Snell
parent b9abeeccc0
commit 41567ee9d8
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/pummel/test-child-process-spawn-loop.js
View File

@ -4,26 +4,26 @@ const assert = require('assert');
const spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
var SIZE = 1000 * 1024; const SIZE = 1000 * 1024;
var N = 40; const N = 40;
var finished = false; let finished = false;
function doSpawn(i) { function doSpawn(i) {
var child = spawn('python', ['-c', 'print ' + SIZE + ' * "C"']); const child = spawn('python', ['-c', 'print ' + SIZE + ' * "C"']);
var count = 0; let count = 0;
child.stdout.setEncoding('ascii'); child.stdout.setEncoding('ascii');
child.stdout.on('data', function(chunk) { child.stdout.on('data', (chunk) => {
count += chunk.length; count += chunk.length;
}); });
child.stderr.on('data', function(chunk) { child.stderr.on('data', (chunk) => {
console.log('stderr: ' + chunk); console.log('stderr: ' + chunk);
}); });
child.on('close', function() { child.on('close', () => {
// + 1 for \n or + 2 for \r\n on Windows // + 1 for \n or + 2 for \r\n on Windows
assert.equal(SIZE + (common.isWindows ? 2 : 1), count); assert.strictEqual(SIZE + (common.isWindows ? 2 : 1), count);
if (i < N) { if (i < N) {
doSpawn(i + 1); doSpawn(i + 1);
} else { } else {
@ -34,6 +34,6 @@ function doSpawn(i) {
doSpawn(0); doSpawn(0);
process.on('exit', function() { process.on('exit', () => {
assert.ok(finished); assert.ok(finished);
}); });