1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: add default options for *stat()

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/29114
Fixes: https://github.com/nodejs/node/issues/29113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Tony Brix 2019-08-14 00:15:10 -05:00 committed by Rich Trott
parent 841df6a9b6
commit 4111c57f7c
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/fs.js
View File

@ -796,7 +796,7 @@ function readdirSync(path, options) {
return options.withFileTypes ? getDirents(path, result) : result; return options.withFileTypes ? getDirents(path, result) : result;
} }
function fstat(fd, options, callback) { function fstat(fd, options = { bigint: false }, callback) {
if (typeof options === 'function') { if (typeof options === 'function') {
callback = options; callback = options;
options = {}; options = {};
@ -807,7 +807,7 @@ function fstat(fd, options, callback) {
binding.fstat(fd, options.bigint, req); binding.fstat(fd, options.bigint, req);
} }
function lstat(path, options, callback) { function lstat(path, options = { bigint: false }, callback) {
if (typeof options === 'function') { if (typeof options === 'function') {
callback = options; callback = options;
options = {}; options = {};
@ -819,7 +819,7 @@ function lstat(path, options, callback) {
binding.lstat(pathModule.toNamespacedPath(path), options.bigint, req); binding.lstat(pathModule.toNamespacedPath(path), options.bigint, req);
} }
function stat(path, options, callback) { function stat(path, options = { bigint: false }, callback) {
if (typeof options === 'function') { if (typeof options === 'function') {
callback = options; callback = options;
options = {}; options = {};

11
test/parallel/test-fs-stat.js
View File

@ -154,3 +154,14 @@ fs.stat(__filename, common.mustCall(function(err, s) {
} }
); );
}); });
// Should not throw an error
fs.stat(__filename, undefined, common.mustCall(() => {}));
fs.open(__filename, 'r', undefined, common.mustCall((err, fd) => {
// Should not throw an error
fs.fstat(fd, undefined, common.mustCall(() => {}));
}));
// Should not throw an error
fs.lstat(__filename, undefined, common.mustCall(() => {}));