1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix errors in test-buffer-alloc.js

Browse Source 
This fixes test code that was mistaken landed by me this morning. (Code
& Learn rush gone bad.) Sorry. Please fast track.

PR-URL: https://github.com/nodejs/node/pull/23645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This commit is contained in:
Rich Trott 2018-10-13 13:07:21 -07:00
parent 882e0225d5
commit 401dac324c
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/parallel/test-buffer-alloc.js
View File

@ -79,6 +79,11 @@ const outOfBoundsError = {
type: RangeError type: RangeError
}; };
const outOfRangeError = {
code: 'ERR_OUT_OF_RANGE',
type: RangeError
};
// try to write a 0-length string beyond the end of b // try to write a 0-length string beyond the end of b
common.expectsError(() => b.write('', 2048), outOfBoundsError); common.expectsError(() => b.write('', 2048), outOfBoundsError);
@ -787,31 +792,31 @@ Buffer.from(Buffer.allocUnsafe(0), 0, 0);
// issue GH-5587 // issue GH-5587
common.expectsError( common.expectsError(
() => Buffer.alloc(8).writeFloatLE(0, 5), () => Buffer.alloc(8).writeFloatLE(0, 5),
outOfBoundsError outOfRangeError
); );
common.expectsError( common.expectsError(
() => Buffer.alloc(16).writeDoubleLE(0, 9), () => Buffer.alloc(16).writeDoubleLE(0, 9),
outOfBoundsError outOfRangeError
); );
// attempt to overflow buffers, similar to previous bug in array buffers // attempt to overflow buffers, similar to previous bug in array buffers
common.expectsError( common.expectsError(
() => Buffer.allocUnsafe(8).writeFloatLE(0.0, 0xffffffff), () => Buffer.allocUnsafe(8).writeFloatLE(0.0, 0xffffffff),
outOfBoundsError outOfRangeError
); );
common.expectsError( common.expectsError(
() => Buffer.allocUnsafe(8).writeFloatLE(0.0, 0xffffffff), () => Buffer.allocUnsafe(8).writeFloatLE(0.0, 0xffffffff),
outOfBoundsError outOfRangeError
); );
// ensure negative values can't get past offset // ensure negative values can't get past offset
common.expectsError( common.expectsError(
() => Buffer.allocUnsafe(8).writeFloatLE(0.0, -1), () => Buffer.allocUnsafe(8).writeFloatLE(0.0, -1),
outOfBoundsError outOfRangeError
); );
common.expectsError( common.expectsError(
() => Buffer.allocUnsafe(8).writeFloatLE(0.0, -1), () => Buffer.allocUnsafe(8).writeFloatLE(0.0, -1),
outOfBoundsError outOfRangeError
); );
// test for common write(U)IntLE/BE // test for common write(U)IntLE/BE
@ -1005,7 +1010,7 @@ common.expectsError(() => {
const a = Buffer.alloc(1); const a = Buffer.alloc(1);
const b = Buffer.alloc(1); const b = Buffer.alloc(1);
a.copy(b, 0, 0x100000000, 0x100000001); a.copy(b, 0, 0x100000000, 0x100000001);
}, outOfBoundsError); }, outOfRangeError);
// Unpooled buffer (replaces SlowBuffer) // Unpooled buffer (replaces SlowBuffer)
{ {