1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: cleanup test-child-process-exec-env.js

Browse Source 
Replace equal with strictEqual, use const instead of var and
improve test with use of assert.notStrictEqual

PR-URL: https://github.com/nodejs/node/pull/8600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This commit is contained in:
Yevgen Safronov 2016-09-17 11:40:06 +02:00 committed by Ilkka Myller
parent 80620d8665
commit 4019c321d4
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/parallel/test-child-process-exec-env.js
View File

@ -1,11 +1,11 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var exec = require('child_process').exec; const exec = require('child_process').exec;
var success_count = 0; let success_count = 0;
var error_count = 0; let error_count = 0;
var response = ''; let response = '';
var child; let child;
function after(err, stdout, stderr) { function after(err, stdout, stderr) {
if (err) { if (err) {
@ -13,10 +13,10 @@ function after(err, stdout, stderr) {
console.log('error!: ' + err.code); console.log('error!: ' + err.code);
console.log('stdout: ' + JSON.stringify(stdout)); console.log('stdout: ' + JSON.stringify(stdout));
console.log('stderr: ' + JSON.stringify(stderr)); console.log('stderr: ' + JSON.stringify(stderr));
assert.equal(false, err.killed); assert.strictEqual(false, err.killed);
} else { } else {
success_count++; success_count++;
assert.equal(true, stdout != ''); assert.notStrictEqual('', stdout);
} }
} }
@ -33,7 +33,7 @@ child.stdout.on('data', function(chunk) {
process.on('exit', function() { process.on('exit', function() {
console.log('response: ', response); console.log('response: ', response);
assert.equal(1, success_count); assert.strictEqual(1, success_count);
assert.equal(0, error_count); assert.strictEqual(0, error_count);
assert.ok(response.indexOf('HELLO=WORLD') >= 0); assert.ok(response.indexOf('HELLO=WORLD') >= 0);
}); });