1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: fix free http-parser too early

Browse Source 
when the status code is 100 (Continue).

Fixes #2636.
This commit is contained in:
koichik 2012-01-31 00:16:01 +09:00
parent b221fe9b29
commit 3fd13c6426
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/http.js
View File

@ -1169,7 +1169,11 @@ ClientRequest.prototype.onSocket = function(socket) {
socket.destroy(); socket.destroy();
} }
freeParser(); freeParser();
} else if (parser.incoming && parser.incoming.complete) { } else if (parser.incoming && parser.incoming.complete &&
// When the status code is 100 (Continue), the server will
// send a final response after this client sends a request
// body. So, we must not free the parser.
parser.incoming.statusCode !== 100) {
freeParser(); freeParser();
} }
}; };

4
test/simple/test-http-expect-continue.js
View File

@ -44,7 +44,9 @@ server.on('checkContinue', function(req, res) {
common.debug('Server got Expect: 100-continue...'); common.debug('Server got Expect: 100-continue...');
res.writeContinue(); res.writeContinue();
sent_continue = true; sent_continue = true;
handler(req, res); setTimeout(function() {
handler(req, res);
}, 100);
}); });
server.listen(common.PORT); server.listen(common.PORT);