1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http2: Expose Http2ServerRequest/Response

Browse Source 
In order for express (and possibly other libraries) to get and use
the Http2ServerRequest/Response - expose them in the http2 exports.
Same as is done in http module.

PR-URL: https://github.com/nodejs/node/pull/14690
Ref: https://github.com/expressjs/express/issues/3390
Fixes: https://github.com/nodejs/node/issues/14672
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
Pini Houri 2017-08-11 00:12:28 +03:00 committed by Benjamin Gruenbaum
parent eab2bea46f
commit 3f5d944ace
4 changed files with 37 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/http2.js
View File

@ -13,7 +13,9 @@ const {
getUnpackedSettings,
createServer,
createSecureServer,
connect
connect,
Http2ServerRequest,
Http2ServerResponse,
} = require('internal/http2/core');
module.exports = {
@ -23,5 +25,7 @@ module.exports = {
getUnpackedSettings,
createServer,
createSecureServer,
connect
connect,
Http2ServerResponse,
Http2ServerRequest,
};

6
lib/internal/http2/compat.js
View File

@ -573,4 +573,8 @@ function onServerStream(stream, headers, flags) {
server.emit('request', request, response);
}
module.exports = { onServerStream };
module.exports = {
onServerStream,
Http2ServerRequest,
Http2ServerResponse,
};

9
lib/internal/http2/core.js
View File

@ -15,7 +15,10 @@ const fs = require('fs');
const errors = require('internal/errors');
const { Duplex } = require('stream');
const { URL } = require('url');
const { onServerStream } = require('internal/http2/compat');
const { onServerStream,
Http2ServerRequest,
Http2ServerResponse,
} = require('internal/http2/compat');
const { utcDate } = require('internal/http');
const { _connectionListener: httpConnectionListener } = require('http');
const { isUint8Array } = process.binding('util');
@ -2552,7 +2555,9 @@ module.exports = {
getUnpackedSettings,
createServer,
createSecureServer,
connect
connect,
Http2ServerRequest,
Http2ServerResponse
};
/* eslint-enable no-use-before-define */

19
test/parallel/test-http2-request-response-proto.js Normal file
View File

@ -0,0 +1,19 @@
// Flags: --expose-http2
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const {
Http2ServerRequest,
Http2ServerResponse,
} = http2;
const protoRequest = Object.create(Http2ServerRequest.prototype);
const protoResponse = Object.create(Http2ServerResponse.prototype);
assert.strictEqual(protoRequest instanceof Http2ServerRequest, true);
assert.strictEqual(protoResponse instanceof Http2ServerResponse, true);