1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dgram: change Socket.bind() to return itself

Browse Source 
This commit changes `lib/dgram.js` Sockets to, when
they are bound to a port / IP, return themselves. This
is done in order to allow chaining of methods and be
in accordance with the `lib/net.js` library.

PR-URL: https://github.com/iojs/io.js/pull/214
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Brendan Ashworth 2014-12-29 12:03:24 -08:00 committed by Ben Noordhuis
parent 0f3d7e6032
commit 3e0057dd61
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/dgram.js
View File

@ -170,7 +170,7 @@ Socket.prototype.bind = function(port /*, address, callback*/) {
if (port instanceof UDP) { if (port instanceof UDP) {
replaceHandle(self, port); replaceHandle(self, port);
startListening(self); startListening(self);
return; return self;
} }
var address; var address;
@ -231,6 +231,8 @@ Socket.prototype.bind = function(port /*, address, callback*/) {
startListening(self); startListening(self);
} }
}); });
return self;
}; };

4
test/parallel/test-dgram-bind.js
View File

@ -29,4 +29,6 @@ socket.on('listening', function () {
socket.close(); socket.close();
}); });
socket.bind(); // should not throw var result = socket.bind(); // should not throw
assert.strictEqual(result, socket); // should have returned itself