1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

repl: don’t write to input stream in editor mode

Browse Source 
Instead of writing to the REPL’s input stream for the alignment
spaces in `.editor` mode, let `readline` handle the spaces
properly (echoing them using `_ttyWrite` and adding them to the
current line buffer).

Fixes: https://github.com/nodejs/node/issues/9189
PR-URL: https://github.com/nodejs/node/pull/9207
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Anna Henningsen 2016-10-20 16:57:40 +02:00
parent 8b6fd4386a
commit 3dfc12793f
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/repl.js
View File

@ -476,7 +476,7 @@ function REPLServer(prompt,
const matches = self._sawKeyPress ? cmd.match(/^\s+/) : null; const matches = self._sawKeyPress ? cmd.match(/^\s+/) : null;
if (matches) { if (matches) {
const prefix = matches[0]; const prefix = matches[0];
self.inputStream.write(prefix); self.write(prefix);
self.line = prefix; self.line = prefix;
self.cursor = prefix.length; self.cursor = prefix.length;
} }

5
test/parallel/test-repl-.editor.js
View File

@ -75,12 +75,15 @@ tests.forEach(run);
// Auto code alignment for .editor mode // Auto code alignment for .editor mode
function testCodeAligment({input, cursor = 0, line = ''}) { function testCodeAligment({input, cursor = 0, line = ''}) {
const stream = new common.ArrayStream(); const stream = new common.ArrayStream();
const outputStream = new common.ArrayStream();
stream.write = () => { throw new Error('Writing not allowed!'); };
const replServer = repl.start({ const replServer = repl.start({
prompt: '> ', prompt: '> ',
terminal: true, terminal: true,
input: stream, input: stream,
output: stream, output: outputStream,
useColors: false useColors: false
}); });