http2: make response.end() return this
PR-URL: https://github.com/nodejs/node/pull/18780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
parent
8118da7430
commit
3d93f39190
@ -2624,11 +2624,16 @@ See [`response.socket`][].
|
|||||||
#### response.end([data][, encoding][, callback])
|
#### response.end([data][, encoding][, callback])
|
||||||
<!-- YAML
|
<!-- YAML
|
||||||
added: v8.4.0
|
added: v8.4.0
|
||||||
|
changes:
|
||||||
|
- version: REPLACEME
|
||||||
|
pr-url: https://github.com/nodejs/node/pull/18780
|
||||||
|
description: This method now returns a reference to `ServerResponse`.
|
||||||
-->
|
-->
|
||||||
|
|
||||||
* `data` {string|Buffer}
|
* `data` {string|Buffer}
|
||||||
* `encoding` {string}
|
* `encoding` {string}
|
||||||
* `callback` {Function}
|
* `callback` {Function}
|
||||||
|
* Returns: {this}
|
||||||
|
|
||||||
This method signals to the server that all of the response headers and body
|
This method signals to the server that all of the response headers and body
|
||||||
have been sent; that server should consider this message complete.
|
have been sent; that server should consider this message complete.
|
||||||
|
@ -596,6 +596,8 @@ class Http2ServerResponse extends Stream {
|
|||||||
this[kFinish]();
|
this[kFinish]();
|
||||||
else
|
else
|
||||||
stream.end();
|
stream.end();
|
||||||
|
|
||||||
|
return this;
|
||||||
}
|
}
|
||||||
|
|
||||||
destroy(err) {
|
destroy(err) {
|
||||||
|
@ -26,7 +26,7 @@ server.listen(0, common.mustCall(function() {
|
|||||||
|
|
||||||
server.close();
|
server.close();
|
||||||
}));
|
}));
|
||||||
response.end();
|
assert.strictEqual(response.end(), response);
|
||||||
}));
|
}));
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user