1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: favor === over == in crypto tests

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/8176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
Rich Trott 2016-08-18 16:15:39 -07:00
parent 25703dc4fc
commit 3d21907682
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-crypto-authenticated.js
View File

@ -312,7 +312,7 @@ var ciphers = crypto.getCiphers();
for (var i in TEST_CASES) { for (var i in TEST_CASES) {
var test = TEST_CASES[i]; var test = TEST_CASES[i];
if (ciphers.indexOf(test.algo) == -1) { if (ciphers.indexOf(test.algo) === -1) {
common.skip('unsupported ' + test.algo + ' test'); common.skip('unsupported ' + test.algo + ' test');
continue; continue;
} }

2
test/parallel/test-crypto-hmac.js
View File

@ -62,7 +62,7 @@ var wikipedia = [
for (let i = 0, l = wikipedia.length; i < l; i++) { for (let i = 0, l = wikipedia.length; i < l; i++) {
for (const hash in wikipedia[i]['hmac']) { for (const hash in wikipedia[i]['hmac']) {
// FIPS does not support MD5. // FIPS does not support MD5.
if (common.hasFipsCrypto && hash == 'md5') if (common.hasFipsCrypto && hash === 'md5')
continue; continue;
const result = crypto.createHmac(hash, wikipedia[i]['key']) const result = crypto.createHmac(hash, wikipedia[i]['key'])
.update(wikipedia[i]['data']) .update(wikipedia[i]['data'])

2
test/pummel/test-crypto-dh.js
View File

@ -41,7 +41,7 @@ for (const name in hashes) {
for (const name in hashes) { for (const name in hashes) {
// modp1 is 768 bits, FIPS requires >= 1024 // modp1 is 768 bits, FIPS requires >= 1024
if (name == 'modp1' && common.hasFipsCrypto) if (name === 'modp1' && common.hasFipsCrypto)
continue; continue;
var group1 = crypto.getDiffieHellman(name); var group1 = crypto.getDiffieHellman(name);
var group2 = crypto.getDiffieHellman(name); var group2 = crypto.getDiffieHellman(name);