1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: replace var with let/const in cluster benchmark

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/31042
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
dnlup 2019-12-20 18:14:16 +01:00 committed by Rich Trott
parent 51aca6d9f1
commit 3cec1a2969
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
benchmark/cluster/echo.js
View File

@ -19,10 +19,10 @@ if (cluster.isMaster) {
serialization serialization
}) { }) {
const expectedPerBroadcast = sendsPerBroadcast * workers; const expectedPerBroadcast = sendsPerBroadcast * workers;
var readies = 0; let readies = 0;
var broadcasts = 0; let broadcasts = 0;
var msgCount = 0; let msgCount = 0;
var data; let data;
cluster.settings.serialization = serialization; cluster.settings.serialization = serialization;
@ -37,7 +37,7 @@ if (cluster.isMaster) {
throw new Error('Unsupported payload type'); throw new Error('Unsupported payload type');
} }
for (var i = 0; i < workers; ++i) for (let i = 0; i < workers; ++i)
cluster.fork().on('online', onOnline).on('message', onMessage); cluster.fork().on('online', onOnline).on('message', onMessage);
function onOnline() { function onOnline() {
@ -48,16 +48,15 @@ if (cluster.isMaster) {
} }
function broadcast() { function broadcast() {
var id;
if (broadcasts++ === n) { if (broadcasts++ === n) {
bench.end(n); bench.end(n);
for (id in cluster.workers) for (const id in cluster.workers)
cluster.workers[id].disconnect(); cluster.workers[id].disconnect();
return; return;
} }
for (id in cluster.workers) { for (const id in cluster.workers) {
const worker = cluster.workers[id]; const worker = cluster.workers[id];
for (var i = 0; i < sendsPerBroadcast; ++i) for (let i = 0; i < sendsPerBroadcast; ++i)
worker.send(data); worker.send(data);
} }
} }