1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools: expose skip output to test runner

Browse Source 
In the TAP protocol, skips are flagged as ok. Expose more
information so we can understand if the test was skipped or not.

PR-URL: https://github.com/nodejs/io.js/pull/2130
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Johan Bergström 2015-07-08 10:37:43 +10:00
parent 24dd016deb
commit 3cbb5870e5
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/test.py
View File

@ -49,6 +49,7 @@ from datetime import datetime
from Queue import Queue, Empty from Queue import Queue, Empty
logger = logging.getLogger('testrunner') logger = logging.getLogger('testrunner')
skip_regex = re.compile(r'# SKIP\S*\s+(.*)', re.IGNORECASE)
VERBOSE = False VERBOSE = False
@ -256,7 +257,12 @@ class TapProgressIndicator(SimpleProgressIndicator):
for l in output.output.stdout.splitlines(): for l in output.output.stdout.splitlines():
logger.info('#' + l) logger.info('#' + l)
else: else:
logger.info('ok %i - %s' % (self._done, command)) skip = skip_regex.search(output.output.stdout)
if skip:
logger.info(
'ok %i - %s # skip %s' % (self._done, command, skip.group(1)))
else:
logger.info('ok %i - %s' % (self._done, command))
duration = output.test.duration duration = output.test.duration
@ -1259,10 +1265,10 @@ def BuildOptions():
result.add_option("--no-suppress-dialogs", help="Display Windows dialogs for crashing tests", result.add_option("--no-suppress-dialogs", help="Display Windows dialogs for crashing tests",
dest="suppress_dialogs", action="store_false") dest="suppress_dialogs", action="store_false")
result.add_option("--shell", help="Path to V8 shell", default="shell") result.add_option("--shell", help="Path to V8 shell", default="shell")
result.add_option("--store-unexpected-output", result.add_option("--store-unexpected-output",
help="Store the temporary JS files from tests that fails", help="Store the temporary JS files from tests that fails",
dest="store_unexpected_output", default=True, action="store_true") dest="store_unexpected_output", default=True, action="store_true")
result.add_option("--no-store-unexpected-output", result.add_option("--no-store-unexpected-output",
help="Deletes the temporary JS files from tests that fails", help="Deletes the temporary JS files from tests that fails",
dest="store_unexpected_output", action="store_false") dest="store_unexpected_output", action="store_false")
return result return result