1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: reverse the order of assertion statement arguments in pingpong test

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23540
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Allan Zheng 2018-10-12 10:27:21 -07:00 committed by Ruben Bridgewater
parent 446771eb65
commit 3c2f9ad0a1
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
test/pummel/test-net-pingpong.js
View File

@ -32,8 +32,8 @@ function pingPongTest(port, host, on_complete) {
let sent_final_ping = false;
const server = net.createServer({ allowHalfOpen: true }, function(socket) {
assert.strictEqual(true, socket.remoteAddress !== null);
assert.strictEqual(true, socket.remoteAddress !== undefined);
assert.strictEqual(socket.remoteAddress !== null, true);
assert.strictEqual(socket.remoteAddress !== undefined, true);
const address = socket.remoteAddress;
if (host === '127.0.0.1') {
assert.strictEqual(address, '127.0.0.1');
@ -50,21 +50,21 @@ function pingPongTest(port, host, on_complete) {
socket.on('data', function(data) {
console.log(`server got: ${JSON.stringify(data)}`);
assert.strictEqual('open', socket.readyState);
assert.strictEqual(true, count <= N);
assert.strictEqual(socket.readyState, 'open');
assert.strictEqual(count <= N, true);
if (/PING/.test(data)) {
socket.write('PONG');
}
});
socket.on('end', function() {
assert.strictEqual('writeOnly', socket.readyState);
assert.strictEqual(socket.readyState, 'writeOnly');
socket.end();
});
socket.on('close', function(had_error) {
assert.strictEqual(false, had_error);
assert.strictEqual('closed', socket.readyState);
assert.strictEqual(had_error, false);
assert.strictEqual(socket.readyState, 'closed');
socket.server.close();
});
});
@ -75,21 +75,21 @@ function pingPongTest(port, host, on_complete) {
client.setEncoding('utf8');
client.on('connect', function() {
assert.strictEqual('open', client.readyState);
assert.strictEqual(client.readyState, 'open');
client.write('PING');
});
client.on('data', function(data) {
console.log(`client got: ${data}`);
assert.strictEqual('PONG', data);
assert.strictEqual(data, 'PONG');
count += 1;
if (sent_final_ping) {
assert.strictEqual('readOnly', client.readyState);
assert.strictEqual(client.readyState, 'readOnly');
return;
} else {
assert.strictEqual('open', client.readyState);
assert.strictEqual(client.readyState, 'open');
}
if (count < N) {
@ -102,8 +102,8 @@ function pingPongTest(port, host, on_complete) {
});
client.on('close', function() {
assert.strictEqual(N + 1, count);
assert.strictEqual(true, sent_final_ping);
assert.strictEqual(count, N + 1);
assert.strictEqual(sent_final_ping, true);
if (on_complete) on_complete();
tests_run += 1;
});
@ -118,5 +118,5 @@ pingPongTest(common.PORT + 1, null);
if (!common.isSunOS) pingPongTest(common.PORT + 2, '::1');
process.on('exit', function() {
assert.strictEqual(common.isSunOS ? 2 : 3, tests_run);
assert.strictEqual(tests_run, common.isSunOS ? 2 : 3);
});