1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: make tls test more rigorous

Browse Source 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: https://github.com/nodejs/node/pull/18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Ben Noordhuis 2018-02-15 11:08:27 +01:00 committed by Ruben Bridgewater
parent 85893afb05
commit 3c29adb84f
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/parallel/test-tls-connect-no-host.js
View File

@ -6,7 +6,6 @@ if (!common.hasCrypto)
common.skip('missing crypto'); common.skip('missing crypto');
const tls = require('tls'); const tls = require('tls');
const assert = require('assert'); const assert = require('assert');
const cert = fixtures.readSync('test_cert.pem'); const cert = fixtures.readSync('test_cert.pem');
@ -15,10 +14,10 @@ const key = fixtures.readSync('test_key.pem');
// https://github.com/nodejs/node/issues/1489 // https://github.com/nodejs/node/issues/1489
// tls.connect(options) with no options.host should accept a cert with // tls.connect(options) with no options.host should accept a cert with
// CN:'localhost' // CN:'localhost'
tls.createServer({ const server = tls.createServer({
key, key,
cert cert
}).listen(0, function() { }).listen(0, common.mustCall(function() {
const socket = tls.connect({ const socket = tls.connect({
port: this.address().port, port: this.address().port,
ca: cert, ca: cert,
@ -26,8 +25,9 @@ tls.createServer({
// but tls.checkServerIdentity() breaks before the fix with: // but tls.checkServerIdentity() breaks before the fix with:
// Error: Hostname/IP doesn't match certificate's altnames: // Error: Hostname/IP doesn't match certificate's altnames:
// "Host: undefined. is not cert's CN: localhost" // "Host: undefined. is not cert's CN: localhost"
}, function() { }, common.mustCall(function() {
assert(socket.authorized); assert(socket.authorized);
process.exit(); socket.destroy();
}); server.close();
}); }));
}));