1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix tls-inception flakiness

Browse Source 
When sending a very large buffer (400000 bytes) the test fails due to
the client socket from the `a` server erroring with `ECONNRESET`.
There's a race condition between the closing of this socket and the `ssl`
socket closing on the other side of the connection. To improve things,
destroy the socket as soon as possible: in the `end` event of the `dest`
socket.

PR-URL: https://github.com/nodejs/node/pull/4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
This commit is contained in:
Santiago Gimeno 2015-12-08 14:57:22 +01:00 committed by Fedor Indutny
parent 86a3bd09b0
commit 3b94991bda
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-tls-inception.js
View File

@ -14,7 +14,7 @@ var net = require('net');
var options, a, b;
var body = new Buffer(4000).fill('A');
var body = new Buffer(400000).fill('A');
options = {
key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')),
@ -32,7 +32,7 @@ a = tls.createServer(options, function(socket) {
dest.pipe(socket);
socket.pipe(dest);
dest.on('close', function() {
dest.on('end', function() {
socket.destroy();
});
});