1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test,async_hooks: match test-ttywrap.readstream

Browse Source 
Match changes made to test-ttywrap.readstream for consistency.

PR-URL: https://github.com/nodejs/node/pull/13991
Fixes: https://github.com/nodejs/node/issues/13984
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
Trevor Norris 2017-07-03 14:40:55 -06:00 committed by Refael Ackermann
parent 250d50b380
commit 3b4010be31
No known key found for this signature in database
GPG Key ID: CD704BD80FDDDB64
1 changed files with 29 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
test/async-hooks/test-ttywrap.writestream.js
View File

@ -1,64 +1,47 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const tty_fd = common.getTTYfd();
if (tty_fd < 0)
common.skip('no valid TTY fd available');
const assert = require('assert'); const assert = require('assert');
// general hook test setup
const tick = require('./tick'); const tick = require('./tick');
const initHooks = require('./init-hooks'); const initHooks = require('./init-hooks');
const { checkInvocations } = require('./hook-checks'); const { checkInvocations } = require('./hook-checks');
const ttyStream = (() => {
try {
return new (require('tty').WriteStream)(tty_fd);
} catch (e) {
return null;
}
})();
if (ttyStream === null)
common.skip('no valid TTY fd available');
const hooks = initHooks(); const hooks = initHooks();
hooks.enable(); hooks.enable();
const as = hooks.activitiesOfTypes('TTYWRAP'); if (!process.stdout.isTTY)
assert.strictEqual(as.length, 1); return common.skip('no valid writable TTY available');
const tty = as[0];
// test specific setup
const checkInitOpts = { init: 1 };
const checkEndedOpts = { init: 1, before: 1, after: 1, destroy: 1 };
// test code
//
// listen to stdin except on Windows
const activities = hooks.activitiesOfTypes('TTYWRAP');
assert.strictEqual(activities.length, 1);
const tty = activities[0];
assert.strictEqual(tty.type, 'TTYWRAP'); assert.strictEqual(tty.type, 'TTYWRAP');
assert.strictEqual(typeof tty.uid, 'number'); assert.strictEqual(typeof tty.uid, 'number');
assert.strictEqual(typeof tty.triggerAsyncId, 'number'); assert.strictEqual(typeof tty.triggerAsyncId, 'number');
checkInvocations(tty, { init: 1 }, 'when tty created'); checkInvocations(tty, checkInitOpts, 'when tty created');
ttyStream const delayedOnCloseHandler = common.mustCall(() => {
.on('finish', common.mustCall(onfinish)) checkInvocations(tty, checkEndedOpts, 'when tty ended');
.end(common.mustCall(onend)); });
process.stdout.on('error', (err) => assert.fail(err));
checkInvocations(tty, { init: 1 }, 'when tty.end() was invoked '); process.stdout.on('close', common.mustCall(() =>
tick(2, delayedOnCloseHandler)
function onend() {
tick(2, common.mustCall(() =>
checkInvocations(
tty, { init: 1, before: 1, after: 1, destroy: 1 },
'when tty ended ')
)); ));
} process.stdout.destroy();
checkInvocations(tty, checkInitOpts, 'when tty.end() was invoked');
function onfinish() { process.on('exit', () => {
tick(2, common.mustCall(() =>
checkInvocations(
tty, { init: 1, before: 1, after: 1, destroy: 1 },
'when tty ended ')
));
}
process.on('exit', onexit);
function onexit() {
hooks.disable(); hooks.disable();
hooks.sanityCheck('TTYWRAP'); hooks.sanityCheck('TTYWRAP');
checkInvocations(tty, { init: 1, before: 1, after: 1, destroy: 1 }, checkInvocations(tty, checkEndedOpts, 'when process exits');
'when process exits'); });
}