1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky test-inspector-connect-main-thread

Browse Source 
Using `console.log()` likely interferes with the functionality of the
test, which also checks the interaction between inspector
and `console.log()` as part of the test. Using `process._rawDebug()`
solves that issue.

Refs: https://github.com/nodejs/node/pull/28870
Refs: https://github.com/nodejs/node/pull/29582

PR-URL: https://github.com/nodejs/node/pull/29588
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
Anna Henningsen 2019-09-17 13:50:04 +02:00 committed by Rich Trott
parent 49cf67efd6
commit 3adec43791
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-inspector-connect-main-thread.js
View File

@ -27,10 +27,10 @@ async function post(session, method, params) {
session.post(method, params, (error, success) => {
messagesSent.push(method);
if (error) {
console.log(`Message ${method} produced an error`);
process._rawDebug(`Message ${method} produced an error`);
reject(error);
} else {
console.log(`Message ${method} was sent`);
process._rawDebug(`Message ${method} was sent`);
resolve(success);
}
});