1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove unused deprecation code

Browse Source 
Currently there are two tests that specify a third argument, a
deprecation code string, when calling common.expectWarning. The
function only takes two arguments and this third argument is not used.

This commit removes the deprecation code.

PR-URL: https://github.com/nodejs/node/pull/19317
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Daniel Bevenius 2018-03-13 06:56:06 +01:00
parent 536190f174
commit 3ad7c1ae97
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/parallel/test-process-assert.js
View File

@ -4,8 +4,7 @@ const assert = require('assert');
common.expectWarning( common.expectWarning(
'DeprecationWarning', 'DeprecationWarning',
'process.assert() is deprecated. Please use the `assert` module instead.', 'process.assert() is deprecated. Please use the `assert` module instead.'
'DEP0100'
); );
assert.strictEqual(process.assert(1, 'error'), undefined); assert.strictEqual(process.assert(1, 'error'), undefined);

3
test/parallel/test-process-env-deprecation.js
View File

@ -8,8 +8,7 @@ common.expectWarning(
'DeprecationWarning', 'DeprecationWarning',
'Assigning any value other than a string, number, or boolean to a ' + 'Assigning any value other than a string, number, or boolean to a ' +
'process.env property is deprecated. Please make sure to convert the value ' + 'process.env property is deprecated. Please make sure to convert the value ' +
'to a string before setting process.env with it.', 'to a string before setting process.env with it.'
'DEP0104'
); );
process.env.ABC = undefined; process.env.ABC = undefined;