1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: fix comments in bidirectionalIndexOf

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/10162
Fixes: https://github.com/nodejs/node/issues/9801
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
dcposch@dcpos.ch 2016-12-07 00:47:38 -08:00 committed by Roman Reiss
parent d0112fc716
commit 39f65e6656
No known key found for this signature in database
GPG Key ID: 2E62B41C93869443
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/buffer.js
View File

@ -598,9 +598,10 @@ function bidirectionalIndexOf(buffer, val, byteOffset, encoding, dir) {
} else if (byteOffset < -0x80000000) { } else if (byteOffset < -0x80000000) {
byteOffset = -0x80000000; byteOffset = -0x80000000;
} }
byteOffset = +byteOffset; // Coerce to Number. // Coerce to Number. Values like null and [] become 0.
if (isNaN(byteOffset)) { byteOffset = +byteOffset;
// If the offset is undefined, null, NaN, "foo", etc, search whole buffer. // If the offset is undefined, "foo", {}, coerces to NaN, search whole buffer.
if (Number.isNaN(byteOffset)) {
byteOffset = dir ? 0 : (buffer.length - 1); byteOffset = dir ? 0 : (buffer.length - 1);
} }
dir = !!dir; // Cast to bool. dir = !!dir; // Cast to bool.