1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-net-dns-error

Browse Source 
- Use `common.mustCall()` and `common.mustNotCall()`.
- Use ternary operator.

PR-URL: https://github.com/nodejs/node/pull/19640
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Luigi Pinca 2018-03-27 19:35:03 +02:00
parent a34f1e3245
commit 37db277bb4
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/parallel/test-net-dns-error.js
View File

@ -21,27 +21,20 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert');
const assert = require('assert');
const net = require('net'); const net = require('net');
const host = '*'.repeat(256); const host = '*'.repeat(256);
const errCode = common.isOpenBSD ? 'EAI_FAIL' : 'ENOTFOUND';
let errCode = 'ENOTFOUND'; const socket = net.connect(42, host, common.mustNotCall());
if (common.isOpenBSD)
errCode = 'EAI_FAIL';
function do_not_call() {
throw new Error('This function should not have been called.');
}
const socket = net.connect(42, host, do_not_call);
socket.on('error', common.mustCall(function(err) { socket.on('error', common.mustCall(function(err) {
assert.strictEqual(err.code, errCode); assert.strictEqual(err.code, errCode);
})); }));
socket.on('lookup', function(err, ip, type) { socket.on('lookup', common.mustCall(function(err, ip, type) {
assert(err instanceof Error); assert(err instanceof Error);
assert.strictEqual(err.code, errCode); assert.strictEqual(err.code, errCode);
assert.strictEqual(ip, undefined); assert.strictEqual(ip, undefined);
assert.strictEqual(type, undefined); assert.strictEqual(type, undefined);
}); }));