1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

path: fix slice OOB in trim

Browse Source 
Internal function trim(arr). 2nd parameter of slice() should be slice's
end index (not included). Because of function normalize() (called before
trim()), "start" is always zero so the bug -for now- has no effect, but
its a bug waiting to happen.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
Lucio M. Tato 2014-08-02 02:33:35 -03:00 committed by Trevor Norris
parent aab126bb06
commit 37c2a52833
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/path.js
View File

@ -269,7 +269,7 @@ if (isWindows) {
} }
if (start > end) return []; if (start > end) return [];
return arr.slice(start, end - start + 1); return arr.slice(start, end + 1);
} }
var toParts = trim(to.split('\\')); var toParts = trim(to.split('\\'));
@ -413,7 +413,7 @@ if (isWindows) {
} }
if (start > end) return []; if (start > end) return [];
return arr.slice(start, end - start + 1); return arr.slice(start, end + 1);
} }
var fromParts = trim(from.split('/')); var fromParts = trim(from.split('/'));