1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: remove deprecated getters for internals

Browse Source 
Remove the getters introduced in 75a19fb379c2d936c6.

PR-URL: https://github.com/nodejs/node/pull/17141
Refs: https://github.com/nodejs/node/pull/14449
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Anna Henningsen 2017-11-19 22:24:22 +01:00 committed by James M Snell
parent 8f50407714
commit 3701b02309
2 changed files with 1 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/api/deprecations.md
View File

@ -640,7 +640,7 @@ Type: End-of-Life
<a id="DEP0073"></a> <a id="DEP0073"></a>
### DEP0073: Several internal properties of net.Server ### DEP0073: Several internal properties of net.Server
Type: Runtime Type: End-of-Life
Accessing several internal, undocumented properties of `net.Server` instances Accessing several internal, undocumented properties of `net.Server` instances
with inappropriate names has been deprecated. with inappropriate names has been deprecated.

28
lib/net.js
View File

@ -1734,34 +1734,6 @@ if (process.platform === 'win32') {
_setSimultaneousAccepts = function(handle) {}; _setSimultaneousAccepts = function(handle) {};
} }
// TODO(addaleax): Remove these after the Node 9.x branch cut.
Object.defineProperty(Server.prototype, '_usingSlaves', {
get: internalUtil.deprecate(function() {
return this._usingWorkers;
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
set: internalUtil.deprecate((val) => {
this._usingWorkers = val;
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
configurable: true, enumerable: false
});
Object.defineProperty(Server.prototype, '_slaves', {
get: internalUtil.deprecate(function() {
return this._workers;
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
set: internalUtil.deprecate((val) => {
this._workers = val;
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
configurable: true, enumerable: false
});
Object.defineProperty(Server.prototype, '_setupSlave', {
value: internalUtil.deprecate(function(socketList) {
return this._setupWorker(socketList);
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
configurable: true, enumerable: false
});
module.exports = { module.exports = {
_createServerHandle: createServerHandle, _createServerHandle: createServerHandle,
_normalizeArgs: normalizeArgs, _normalizeArgs: normalizeArgs,