1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: simplify ReadFloatGeneric offset checks

Browse Source
This commit is contained in:
Ben Noordhuis 2013-05-26 21:41:20 +02:00
parent ef0926ce42
commit 36ebff0470
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/node_buffer.cc
View File

@ -396,12 +396,11 @@ static inline void Swizzle(char* start, unsigned int len) {
template <typename T, enum Endianness endianness> template <typename T, enum Endianness endianness>
Handle<Value> ReadFloatGeneric(const Arguments& args) { Handle<Value> ReadFloatGeneric(const Arguments& args) {
double offset_tmp = args[0]->NumberValue(); size_t offset = args[0]->Uint32Value();
int64_t offset = static_cast<int64_t>(offset_tmp);
bool doAssert = !args[1]->BooleanValue(); bool doAssert = !args[1]->BooleanValue();
if (doAssert) { if (doAssert) {
if (offset_tmp != offset || offset < 0) if (!args[0]->IsUint32())
return ThrowTypeError("offset is not uint"); return ThrowTypeError("offset is not uint");
size_t len = static_cast<size_t>( size_t len = static_cast<size_t>(
args.This()->GetIndexedPropertiesExternalArrayDataLength()); args.This()->GetIndexedPropertiesExternalArrayDataLength());