1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove flaky designation for test on AIX

Browse Source 
https://github.com/nodejs/node/issues/5085 has been completed so
presumably test-fs-watch is not flaky on AIX anymore. Remove flaky
designation from sequential.status.

PR-URL: https://github.com/nodejs/node/pull/12564
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This commit is contained in:
Rich Trott 2017-04-20 22:35:16 -07:00 committed by James M Snell
parent 9cc39ff79d
commit 3663ac27c1
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/sequential/sequential.status
View File

@ -17,9 +17,4 @@ test-benchmark-child-process : PASS,FLAKY
[$system==freebsd] [$system==freebsd]
# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix] [$system==aix]
test-fs-watch : FAIL,PASS

5
test/sequential/test-fs-watch.js
View File

@ -27,7 +27,8 @@ const fs = require('fs');
const expectFilePath = common.isWindows || const expectFilePath = common.isWindows ||
common.isLinux || common.isLinux ||
common.isOSX; common.isOSX ||
common.isAix;
let watchSeenOne = 0; let watchSeenOne = 0;
let watchSeenTwo = 0; let watchSeenTwo = 0;
@ -101,7 +102,7 @@ const filepathThree = path.join(testsubdir, filenameThree);
assert.doesNotThrow( assert.doesNotThrow(
function() { function() {
const watcher = fs.watch(testsubdir, function(event, filename) { const watcher = fs.watch(testsubdir, function(event, filename) {
const renameEv = common.isSunOS ? 'change' : 'rename'; const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
assert.strictEqual(renameEv, event); assert.strictEqual(renameEv, event);
if (expectFilePath) { if (expectFilePath) {
assert.strictEqual('newfile.txt', filename); assert.strictEqual('newfile.txt', filename);