test: remove flaky designation for test on AIX
https://github.com/nodejs/node/issues/5085 has been completed so presumably test-fs-watch is not flaky on AIX anymore. Remove flaky designation from sequential.status. PR-URL: https://github.com/nodejs/node/pull/12564 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This commit is contained in:
parent
9cc39ff79d
commit
3663ac27c1
@ -17,9 +17,4 @@ test-benchmark-child-process : PASS,FLAKY
|
||||
|
||||
[$system==freebsd]
|
||||
|
||||
# fs-watch currently needs special configuration on AIX and we
|
||||
# want to improve under https://github.com/nodejs/node/issues/5085.
|
||||
# Tests are disabled so CI can be green and we can spot other
|
||||
# regressions until this work is complete
|
||||
[$system==aix]
|
||||
test-fs-watch : FAIL,PASS
|
||||
|
@ -27,7 +27,8 @@ const fs = require('fs');
|
||||
|
||||
const expectFilePath = common.isWindows ||
|
||||
common.isLinux ||
|
||||
common.isOSX;
|
||||
common.isOSX ||
|
||||
common.isAix;
|
||||
|
||||
let watchSeenOne = 0;
|
||||
let watchSeenTwo = 0;
|
||||
@ -101,7 +102,7 @@ const filepathThree = path.join(testsubdir, filenameThree);
|
||||
assert.doesNotThrow(
|
||||
function() {
|
||||
const watcher = fs.watch(testsubdir, function(event, filename) {
|
||||
const renameEv = common.isSunOS ? 'change' : 'rename';
|
||||
const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
|
||||
assert.strictEqual(renameEv, event);
|
||||
if (expectFilePath) {
|
||||
assert.strictEqual('newfile.txt', filename);
|
||||
|
Loading…
x
Reference in New Issue
Block a user