1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: update test-http-response-multiheaders to use countdown

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
This commit is contained in:
hmammedzadeh 2017-12-03 21:16:05 +01:00 committed by Jon Moss
parent 996bfccd17
commit 35c01d84a8
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/parallel/test-http-response-multiheaders.js
View File

@ -3,6 +3,7 @@
const common = require('../common'); const common = require('../common');
const http = require('http'); const http = require('http');
const assert = require('assert'); const assert = require('assert');
const Countdown = require('../common/countdown');
// Test that certain response header fields do not repeat. // Test that certain response header fields do not repeat.
// 'content-length' should also be in this list but it is // 'content-length' should also be in this list but it is
@ -27,6 +28,7 @@ const norepeat = [
'age', 'age',
'expires' 'expires'
]; ];
const runCount = 2;
const server = http.createServer(function(req, res) { const server = http.createServer(function(req, res) {
const num = req.headers['x-num']; const num = req.headers['x-num'];
@ -47,8 +49,8 @@ const server = http.createServer(function(req, res) {
}); });
server.listen(0, common.mustCall(function() { server.listen(0, common.mustCall(function() {
let count = 0; const countdown = new Countdown(runCount, () => server.close());
for (let n = 1; n <= 2; n++) { for (let n = 1; n <= runCount; n++) {
// this runs twice, the first time, the server will use // this runs twice, the first time, the server will use
// setHeader, the second time it uses writeHead. The // setHeader, the second time it uses writeHead. The
// result on the client side should be the same in // result on the client side should be the same in
@ -58,7 +60,7 @@ server.listen(0, common.mustCall(function() {
http.get( http.get(
{ port: this.address().port, headers: { 'x-num': n } }, { port: this.address().port, headers: { 'x-num': n } },
common.mustCall(function(res) { common.mustCall(function(res) {
if (++count === 2) server.close(); countdown.dec();
for (const name of norepeat) { for (const name of norepeat) {
assert.strictEqual(res.headers[name], 'A'); assert.strictEqual(res.headers[name], 'A');
} }