1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build,deps: add NOMINMAX to V8 Windows builds

Browse Source 
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620

PR-URL: https://github.com/nodejs/node/pull/25852
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
This commit is contained in:
Refael Ackermann 2019-03-13 17:55:15 -04:00 committed by Michaël Zasso
parent 1c494b0a95
commit 3531fe9320
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
deps/v8/gypfiles/toolchain.gypi vendored
View File

@ -996,6 +996,7 @@
['OS=="win"', {
'defines': [
'WIN32',
'NOMINMAX', # Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620
],
# 4351: VS 2005 and later are warning us that they've fixed a bug
# present in VS 2003 and earlier.