1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: reduce runtime

Browse Source 
This refactors some tests to reduce the runtime of those.

PR-URL: https://github.com/nodejs/node/pull/20688
Refs: https://github.com/nodejs/node/issues/20128
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
This commit is contained in:
Ruben Bridgewater 2018-05-12 12:02:38 +02:00
parent c041a2ee5b
commit 352ae23974
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/parallel/test-async-wrap-pop-id-during-load.js
View File

@ -7,15 +7,17 @@ if (process.argv[2] === 'async') {
fn();
throw new Error();
}
(async function() { await fn(); })();
// While the above should error, just in case it doesn't the script shouldn't
// fork itself indefinitely so return early.
return;
return (async function() { await fn(); })();
}
const assert = require('assert');
const { spawnSync } = require('child_process');
const ret = spawnSync(process.execPath, [__filename, 'async']);
const ret = spawnSync(
process.execPath,
['--stack_size=50', __filename, 'async']
);
assert.strictEqual(ret.status, 0);
assert.ok(!/async.*hook/i.test(ret.stderr.toString('utf8', 0, 1024)));
const stderr = ret.stderr.toString('utf8', 0, 2048);
assert.ok(!/async.*hook/i.test(stderr));
assert.ok(stderr.includes('UnhandledPromiseRejectionWarning: Error'), stderr);

8
test/parallel/test-child-process-exec-encoding.js
View File

@ -1,17 +1,17 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const stdoutData = 'foo';
const stderrData = 'bar';
const expectedStdout = `${stdoutData}\n`;
const expectedStderr = `${stderrData}\n`;
if (process.argv[2] === 'child') {
// The following console calls are part of the test.
console.log(stdoutData);
console.error(stderrData);
} else {
const assert = require('assert');
const cp = require('child_process');
const expectedStdout = `${stdoutData}\n`;
const expectedStderr = `${stderrData}\n`;
function run(options, callback) {
const cmd = `"${process.execPath}" "${__filename}" child`;