1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix ::1 error in test-dns-ipv6

Browse Source 
If ::1 can't be resolved, the test should still pass.

PR-URL: https://github.com/nodejs/node/pull/8254
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Gibson Fahnestock 2016-08-26 13:55:00 +01:00 committed by Rich Trott
parent 2501a38b79
commit 3504a98b72
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/internet/test-dns-ipv6.js
View File

@ -179,7 +179,12 @@ TEST(function test_lookup_all_ipv6(done) {
TEST(function test_lookupservice_ip_ipv6(done) { TEST(function test_lookupservice_ip_ipv6(done) {
var req = dns.lookupService('::1', 80, function(err, host, service) { var req = dns.lookupService('::1', 80, function(err, host, service) {
if (err) throw err; if (err) {
// Not skipping the test, rather checking an alternative result,
// i.e. that ::1 may not be configured (e.g. in /etc/hosts)
assert.strictEqual(err.code, 'ENOTFOUND');
return done();
}
assert.equal(typeof host, 'string'); assert.equal(typeof host, 'string');
assert(host); assert(host);
assert(['http', 'www', '80'].includes(service)); assert(['http', 'www', '80'].includes(service));