1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: scope redeclared variable

Browse Source 
`test-assert.js` redeclares a variable with `var`. This change converts
it to a `const` declaration and wraps it in a standalone block to scope
it to just the test that uses it.

PR-URL: https://github.com/nodejs/node/pull/4854
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
This commit is contained in:
Rich Trott 2016-01-13 16:14:28 -08:00
parent 6a73dbad51
commit 34daaa764f
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/parallel/test-assert.js
View File

@ -73,9 +73,11 @@ assert.throws(makeBlock(a.deepEqual, /a/i, /a/));
assert.throws(makeBlock(a.deepEqual, /a/m, /a/)); assert.throws(makeBlock(a.deepEqual, /a/m, /a/));
assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im)); assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im));
var re1 = /a/; {
re1.lastIndex = 3; const re1 = /a/;
assert.throws(makeBlock(a.deepEqual, re1, /a/)); re1.lastIndex = 3;
assert.throws(makeBlock(a.deepEqual, re1, /a/));
}
// 7.4 // 7.4
@ -172,10 +174,11 @@ assert.throws(makeBlock(a.deepStrictEqual, /a/i, /a/));
assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/)); assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/));
assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im)); assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im));
var re1 = /a/; {
re1.lastIndex = 3; const re1 = /a/;
assert.throws(makeBlock(a.deepStrictEqual, re1, /a/)); re1.lastIndex = 3;
assert.throws(makeBlock(a.deepStrictEqual, re1, /a/));
}
// 7.4 - strict // 7.4 - strict
assert.throws(makeBlock(a.deepStrictEqual, 4, '4'), assert.throws(makeBlock(a.deepStrictEqual, 4, '4'),