From 34d988f122c206da692b5c39ec5342fec22b60ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Fri, 16 Mar 2018 15:23:39 +0100 Subject: [PATCH] vm: move options checks from C++ to JS Also introduces stronger type validations for options passed to vm functions. PR-URL: https://github.com/nodejs/node/pull/19398 Reviewed-By: James M Snell Reviewed-By: Joyee Cheung Reviewed-By: Colin Ihrig --- doc/api/vm.md | 3 + lib/internal/bootstrap/loaders.js | 13 +- lib/internal/vm/module.js | 4 + lib/vm.js | 223 +++++++----- src/env.h | 1 - src/node_contextify.cc | 358 +++++++------------- src/node_contextify.h | 11 +- test/parallel/test-vm-basic.js | 111 +++--- test/parallel/test-vm-cached-data.js | 10 +- test/parallel/test-vm-context.js | 28 +- test/parallel/test-vm-is-context.js | 7 - test/parallel/test-vm-options-validation.js | 78 +++++ test/parallel/test-vm-timeout.js | 20 +- 13 files changed, 457 insertions(+), 410 deletions(-) create mode 100644 test/parallel/test-vm-options-validation.js diff --git a/doc/api/vm.md b/doc/api/vm.md index 25efc85cf66..3712fa4f2b1 100644 --- a/doc/api/vm.md +++ b/doc/api/vm.md @@ -618,6 +618,9 @@ console.log(globalVar);