1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: refactor deprecated v8::Function::Call call

Browse Source 
Refs: https://github.com/nodejs/node/pull/23414#issuecomment-428815506

PR-URL: https://github.com/nodejs/node/pull/23804
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Romain Lanz 2018-10-21 18:25:01 +02:00 committed by Refael Ackermann
parent 4194b051e8
commit 341006b144
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/node.cc
View File

@ -1381,9 +1381,8 @@ void FatalException(Isolate* isolate,
fatal_try_catch.SetVerbose(false);
// This will return true if the JS layer handled it, false otherwise
Local<Value> caught =
fatal_exception_function.As<Function>()
->Call(process_object, 1, &error);
MaybeLocal<Value> caught = fatal_exception_function.As<Function>()->Call(
env->context(), process_object, 1, &error);
if (fatal_try_catch.HasTerminated())
return;
@ -1392,7 +1391,7 @@ void FatalException(Isolate* isolate,
// The fatal exception function threw, so we must exit
ReportException(env, fatal_try_catch);
exit(7);
} else if (caught->IsFalse()) {
} else if (caught.ToLocalChecked()->IsFalse()) {
ReportException(env, error, message);
// fatal_exception_function call before may have set a new exit code ->