tools: shorten metadata parsing

PR-URL: https://github.com/nodejs/node/pull/19512
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Tobias Nießen 2018-03-21 15:37:12 +01:00
parent 5b9f8e1d77
commit 337e04054e
No known key found for this signature in database
GPG Key ID: 718207F8FD156B70

View File

@ -13,31 +13,28 @@ function arrify(value) {
} }
function extractAndParseYAML(text) { function extractAndParseYAML(text) {
text = text.trim(); text = text.trim()
.replace(/^<!-- YAML/, '')
text = text.replace(/^<!-- YAML/, '')
.replace(/-->$/, ''); .replace(/-->$/, '');
// js-yaml.safeLoad() throws on error // js-yaml.safeLoad() throws on error
const meta = yaml.safeLoad(text); const meta = yaml.safeLoad(text);
const added = meta.added; if (meta.added) {
if (added) {
// Since semver-minors can trickle down to previous major versions, // Since semver-minors can trickle down to previous major versions,
// features may have been added in multiple versions. // features may have been added in multiple versions.
meta.added = arrify(added); meta.added = arrify(meta.added);
} }
const deprecated = meta.deprecated; if (meta.deprecated) {
if (deprecated) {
// Treat deprecated like added for consistency. // Treat deprecated like added for consistency.
meta.deprecated = arrify(deprecated); meta.deprecated = arrify(meta.deprecated);
} }
meta.changes = meta.changes || []; meta.changes = meta.changes || [];
meta.changes.forEach((entry) => { for (const entry of meta.changes) {
entry.description = entry.description.replace(/^\^\s*/, ''); entry.description = entry.description.replace(/^\^\s*/, '');
}); }
return meta; return meta;
} }