1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

inspector: always set process.binding('inspector').callAndPauseOnStart

Browse Source 
Since `process.binding('inspector')` is loaded during bootstrap,
simply set `process.binding('inspector').callAndPauseOnStart`
unconditionally instead of relying on `agent->WillWaitForConnect()`
which depends on runtime states,

PR-URL: https://github.com/nodejs/node/pull/26793
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Joyee Cheung 2019-03-20 09:21:38 +08:00
parent 83972ff6ac
commit 332032cc52
No known key found for this signature in database
GPG Key ID: 92B78A53C8303B8D
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/inspector_js_api.cc
View File

@ -273,8 +273,6 @@ void Initialize(Local<Object> target, Local<Value> unused,
Local<Context> context, void* priv) { Local<Context> context, void* priv) {
Environment* env = Environment::GetCurrent(context); Environment* env = Environment::GetCurrent(context);
Agent* agent = env->inspector_agent();
v8::Local<v8::Function> consoleCallFunc = v8::Local<v8::Function> consoleCallFunc =
env->NewFunctionTemplate(InspectorConsoleCall, v8::Local<v8::Signature>(), env->NewFunctionTemplate(InspectorConsoleCall, v8::Local<v8::Signature>(),
v8::ConstructorBehavior::kThrow, v8::ConstructorBehavior::kThrow,
@ -287,8 +285,7 @@ void Initialize(Local<Object> target, Local<Value> unused,
env->SetMethod( env->SetMethod(
target, "setConsoleExtensionInstaller", SetConsoleExtensionInstaller); target, "setConsoleExtensionInstaller", SetConsoleExtensionInstaller);
if (agent->WillWaitForConnect()) env->SetMethod(target, "callAndPauseOnStart", CallAndPauseOnStart);
env->SetMethod(target, "callAndPauseOnStart", CallAndPauseOnStart);
env->SetMethod(target, "open", Open); env->SetMethod(target, "open", Open);
env->SetMethodNoSideEffect(target, "url", Url); env->SetMethodNoSideEffect(target, "url", Url);