1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: fix method name, output format

Browse Source 
* add additional newline to HTTP GET JSON responses
* SendTargentsListResponse -> SendListResponse

PR-URL: https://github.com/nodejs/node/pull/9627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Josh Gavant 2016-11-14 15:22:48 -08:00 committed by Anna Henningsen
parent 3295a7feba
commit 31dac410a4
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/inspector_agent.cc
View File

@ -64,7 +64,7 @@ std::string MapToString(const std::map<std::string, std::string> object) {
json << name_value.second << "\""; json << name_value.second << "\"";
first = false; first = false;
} }
json << "\n} ]"; json << "\n} ]\n\n";
return json.str(); return json.str();
} }
@ -250,7 +250,7 @@ class AgentImpl {
void WaitForFrontendMessage(); void WaitForFrontendMessage();
void NotifyMessageReceived(); void NotifyMessageReceived();
State ToState(State state); State ToState(State state);
void SendTargentsListResponse(InspectorSocket* socket); void SendListResponse(InspectorSocket* socket);
bool RespondToGet(InspectorSocket* socket, const std::string& path); bool RespondToGet(InspectorSocket* socket, const std::string& path);
uv_sem_t start_sem_; uv_sem_t start_sem_;
@ -677,7 +677,7 @@ void AgentImpl::OnRemoteDataIO(InspectorSocket* socket,
} }
} }
void AgentImpl::SendTargentsListResponse(InspectorSocket* socket) { void AgentImpl::SendListResponse(InspectorSocket* socket) {
std::map<std::string, std::string> response; std::map<std::string, std::string> response;
response["description"] = "node.js instance"; response["description"] = "node.js instance";
response["faviconUrl"] = "https://nodejs.org/static/favicon.ico"; response["faviconUrl"] = "https://nodejs.org/static/favicon.ico";
@ -710,7 +710,7 @@ bool AgentImpl::RespondToGet(InspectorSocket* socket, const std::string& path) {
return false; return false;
if (match_path_segment(command, "list") || command[0] == '\0') { if (match_path_segment(command, "list") || command[0] == '\0') {
SendTargentsListResponse(socket); SendListResponse(socket);
return true; return true;
} else if (match_path_segment(command, "protocol")) { } else if (match_path_segment(command, "protocol")) {
SendProtocolJson(socket); SendProtocolJson(socket);