1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove string literal from strictEqual()

Browse Source 
Remove 3rd argument from assert.deepStrictEqual() in
test/parallel/test-stream2-writable.js to allow for debugging to work
properly.

PR-URL: https://github.com/nodejs/node/pull/22512
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
This commit is contained in:
Scott Van Gilder 2018-08-24 14:27:00 -06:00 committed by George Adams
parent dd03706d62
commit 31b3273eaa
No known key found for this signature in database
GPG Key ID: 7B8D7E4421A0916D
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/parallel/test-stream2-writable.js
View File

@ -55,7 +55,8 @@ for (let i = 0; i < chunks.length; i++) {
}); });
tw.on('finish', common.mustCall(function() { tw.on('finish', common.mustCall(function() {
assert.deepStrictEqual(tw.buffer, chunks, 'got chunks in the right order'); // got chunks in the right order
assert.deepStrictEqual(tw.buffer, chunks);
})); }));
chunks.forEach(function(chunk) { chunks.forEach(function(chunk) {
@ -72,7 +73,8 @@ for (let i = 0; i < chunks.length; i++) {
}); });
tw.on('finish', common.mustCall(function() { tw.on('finish', common.mustCall(function() {
assert.deepStrictEqual(tw.buffer, chunks, 'got chunks in the right order'); // got chunks in the right order
assert.deepStrictEqual(tw.buffer, chunks);
})); }));
let i = 0; let i = 0;
@ -94,7 +96,8 @@ for (let i = 0; i < chunks.length; i++) {
let drains = 0; let drains = 0;
tw.on('finish', common.mustCall(function() { tw.on('finish', common.mustCall(function() {
assert.deepStrictEqual(tw.buffer, chunks, 'got chunks in the right order'); // got chunks in the right order
assert.deepStrictEqual(tw.buffer, chunks);
assert.strictEqual(drains, 17); assert.strictEqual(drains, 17);
})); }));
@ -139,7 +142,8 @@ for (let i = 0; i < chunks.length; i++) {
undefined ]; undefined ];
tw.on('finish', function() { tw.on('finish', function() {
assert.deepStrictEqual(tw.buffer, chunks, 'got the expected chunks'); // got the expected chunks
assert.deepStrictEqual(tw.buffer, chunks);
}); });
chunks.forEach(function(chunk, i) { chunks.forEach(function(chunk, i) {
@ -177,7 +181,8 @@ for (let i = 0; i < chunks.length; i++) {
undefined ]; undefined ];
tw.on('finish', function() { tw.on('finish', function() {
assert.deepStrictEqual(tw.buffer, chunks, 'got the expected chunks'); // got the expected chunks
assert.deepStrictEqual(tw.buffer, chunks);
}); });
chunks.forEach(function(chunk, i) { chunks.forEach(function(chunk, i) {
@ -205,9 +210,10 @@ for (let i = 0; i < chunks.length; i++) {
tw.on('finish', common.mustCall(function() { tw.on('finish', common.mustCall(function() {
process.nextTick(common.mustCall(function() { process.nextTick(common.mustCall(function() {
assert.deepStrictEqual(tw.buffer, chunks, // got chunks in the right order
'got chunks in the right order'); assert.deepStrictEqual(tw.buffer, chunks);
assert.deepStrictEqual(callbacks._called, chunks, 'called all callbacks'); // called all callbacks
assert.deepStrictEqual(callbacks._called, chunks);
})); }));
})); }));