1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crypto: don't touch ssl_ in Connection

Browse Source 
`ssl_` is a property of SSLWrap class, don't touch it, and definitely
don't zero it in constructor.
This commit is contained in:
Fedor Indutny 2013-08-19 20:34:34 +04:00
parent b9a0eb0688
commit 306f863438
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node_crypto.h
View File

@ -267,7 +267,6 @@ class Connection : public SSLWrap<Connection>, public ObjectWrap {
: SSLWrap<Connection>(sc, kind), : SSLWrap<Connection>(sc, kind),
hello_offset_(0) { hello_offset_(0) {
bio_read_ = bio_write_ = NULL; bio_read_ = bio_write_ = NULL;
ssl_ = NULL;
hello_parser_.Start(SSLWrap<Connection>::OnClientHello, hello_parser_.Start(SSLWrap<Connection>::OnClientHello,
OnClientHelloParseEnd, OnClientHelloParseEnd,
this); this);
@ -275,11 +274,6 @@ class Connection : public SSLWrap<Connection>, public ObjectWrap {
} }
~Connection() { ~Connection() {
if (ssl_ != NULL) {
SSL_free(ssl_);
ssl_ = NULL;
}
#ifdef SSL_CTRL_SET_TLSEXT_SERVERNAME_CB #ifdef SSL_CTRL_SET_TLSEXT_SERVERNAME_CB
sniObject_.Dispose(); sniObject_.Dispose();
sniContext_.Dispose(); sniContext_.Dispose();