1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add case for url.parse throwing a URIError

Browse Source 
The auth property of a URL is decoded via decodeURIComponent,
which can throw a URIError. The test URL here will trigger this.

Adds documentation on the possible errors url.parse can throw.

PR-URL: https://github.com/nodejs/node/pull/12135
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Lovell Fuller 2017-03-30 13:21:49 +01:00 committed by James M Snell
parent eefdf452c3
commit 2ff107dad7
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/api/url.md
View File

@ -259,6 +259,10 @@ added: v0.1.25
The `url.parse()` method takes a URL string, parses it, and returns a URL The `url.parse()` method takes a URL string, parses it, and returns a URL
object. object.
A `TypeError` is thrown if `urlString` is not a string.
A `URIError` is thrown if the `auth` property is present but cannot be decoded.
## url.resolve(from, to) ## url.resolve(from, to)
<!-- YAML <!-- YAML
added: v0.1.25 added: v0.1.25

2
test/parallel/test-url-parse-invalid-input.js
View File

@ -16,3 +16,5 @@ const url = require('url');
].forEach(function(val) { ].forEach(function(val) {
assert.throws(function() { url.parse(val); }, TypeError); assert.throws(function() { url.parse(val); }, TypeError);
}); });
assert.throws(function() { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/);