1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: misc ClientRequest cleanup

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/10654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
This commit is contained in:
Brian White 2017-01-06 03:13:57 -05:00
parent 15c6187aa5
commit 2f7759640e
No known key found for this signature in database
GPG Key ID: 606D7358F94DA209
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/_http_client.js
View File

@ -97,9 +97,7 @@ function ClientRequest(options, cb) {
var port = options.port = options.port || defaultPort || 80;
var host = options.host = options.hostname || options.host || 'localhost';
if (options.setHost === undefined) {
var setHost = true;
}
var setHost = (options.setHost === undefined);
self.socketPath = options.socketPath;
self.timeout = options.timeout;
@ -128,7 +126,7 @@ function ClientRequest(options, cb) {
if (!headersArray) {
if (options.headers) {
var keys = Object.keys(options.headers);
for (var i = 0, l = keys.length; i < l; i++) {
for (var i = 0; i < keys.length; i++) {
var key = keys[i];
self.setHeader(key, options.headers[key]);
}
@ -154,7 +152,6 @@ function ClientRequest(options, cb) {
}
if (options.auth && !this.getHeader('Authorization')) {
//basic auth
this.setHeader('Authorization', 'Basic ' +
Buffer.from(options.auth).toString('base64'));
}