src: remove memory_tracker-inl.h from header files

Inline headers should only be included into the .cc files that use them.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Sam Roberts 2019-05-17 13:11:02 -07:00
parent 6ded4f2bad
commit 2ecef9b5f2
23 changed files with 23 additions and 1 deletions

View File

@ -24,7 +24,7 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
#include "memory_tracker-inl.h" #include "memory_tracker.h"
#include "v8.h" #include "v8.h"
#include <type_traits> // std::remove_reference #include <type_traits> // std::remove_reference

View File

@ -23,6 +23,7 @@
#include "ares.h" #include "ares.h"
#include "async_wrap-inl.h" #include "async_wrap-inl.h"
#include "env-inl.h" #include "env-inl.h"
#include "memory_tracker-inl.h"
#include "node.h" #include "node.h"
#include "req_wrap-inl.h" #include "req_wrap-inl.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -1,6 +1,7 @@
#include "env.h" #include "env.h"
#include "async_wrap.h" #include "async_wrap.h"
#include "memory_tracker-inl.h"
#include "node_buffer.h" #include "node_buffer.h"
#include "node_context_data.h" #include "node_context_data.h"
#include "node_errors.h" #include "node_errors.h"

View File

@ -1,4 +1,5 @@
#include "env-inl.h" #include "env-inl.h"
#include "memory_tracker-inl.h"
#include "stream_base-inl.h" #include "stream_base-inl.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -1,6 +1,7 @@
#include "base_object-inl.h" #include "base_object-inl.h"
#include "inspector_agent.h" #include "inspector_agent.h"
#include "inspector_io.h" #include "inspector_io.h"
#include "memory_tracker-inl.h"
#include "util-inl.h" #include "util-inl.h"
#include "v8.h" #include "v8.h"
#include "v8-inspector.h" #include "v8-inspector.h"

View File

@ -2,6 +2,7 @@
#include <sstream> #include <sstream>
#include "base_object-inl.h" #include "base_object-inl.h"
#include "debug_utils.h" #include "debug_utils.h"
#include "memory_tracker-inl.h"
#include "node_file.h" #include "node_file.h"
#include "node_internals.h" #include "node_internals.h"
#include "v8-inspector.h" #include "v8-inspector.h"

View File

@ -1,6 +1,7 @@
#include "module_wrap.h" #include "module_wrap.h"
#include "env.h" #include "env.h"
#include "memory_tracker-inl.h"
#include "node_errors.h" #include "node_errors.h"
#include "node_url.h" #include "node_url.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -25,6 +25,7 @@
#include "debug_utils.h" #include "debug_utils.h"
#include "env-inl.h" #include "env-inl.h"
#include "memory_tracker-inl.h"
#include "node_binding.h" #include "node_binding.h"
#include "node_internals.h" #include "node_internals.h"
#include "node_main_instance.h" #include "node_main_instance.h"

View File

@ -1,4 +1,5 @@
#include "env-inl.h" #include "env-inl.h"
#include "memory_tracker.h"
#include "node.h" #include "node.h"
#include "node_i18n.h" #include "node_i18n.h"
#include "node_native_module_env.h" #include "node_native_module_env.h"

View File

@ -21,6 +21,7 @@
#include "node_contextify.h" #include "node_contextify.h"
#include "memory_tracker-inl.h"
#include "node_internals.h" #include "node_internals.h"
#include "node_watchdog.h" #include "node_watchdog.h"
#include "base_object-inl.h" #include "base_object-inl.h"

View File

@ -32,6 +32,7 @@
#include "async_wrap-inl.h" #include "async_wrap-inl.h"
#include "base_object-inl.h" #include "base_object-inl.h"
#include "env-inl.h" #include "env-inl.h"
#include "memory_tracker-inl.h"
#include "string_bytes.h" #include "string_bytes.h"
#include "threadpoolwork-inl.h" #include "threadpoolwork-inl.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -20,6 +20,7 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
#include "base_object-inl.h" #include "base_object-inl.h"
#include "memory_tracker-inl.h"
#include "node_crypto_bio.h" #include "node_crypto_bio.h"
#include "openssl/bio.h" #include "openssl/bio.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -21,6 +21,7 @@
#include "node_file.h" #include "node_file.h"
#include "aliased_buffer.h" #include "aliased_buffer.h"
#include "memory_tracker-inl.h"
#include "node_buffer.h" #include "node_buffer.h"
#include "node_process.h" #include "node_process.h"
#include "node_stat_watcher.h" #include "node_stat_watcher.h"

View File

@ -1,5 +1,6 @@
#include "aliased_buffer.h" #include "aliased_buffer.h"
#include "debug_utils.h" #include "debug_utils.h"
#include "memory_tracker-inl.h"
#include "node.h" #include "node.h"
#include "node_buffer.h" #include "node_buffer.h"
#include "node_http2.h" #include "node_http2.h"

View File

@ -1,6 +1,7 @@
#define NODE_EXPERIMENTAL_HTTP 1 #define NODE_EXPERIMENTAL_HTTP 1
#include "node_http_parser_impl.h" #include "node_http_parser_impl.h"
#include "memory_tracker-inl.h"
#include "node_metadata.h" #include "node_metadata.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -2,6 +2,7 @@
#undef NODE_EXPERIMENTAL_HTTP #undef NODE_EXPERIMENTAL_HTTP
#endif #endif
#include "memory_tracker-inl.h"
#include "node_http_parser_impl.h" #include "node_http_parser_impl.h"
#include "node_metadata.h" #include "node_metadata.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -2,6 +2,7 @@
#include "async_wrap-inl.h" #include "async_wrap-inl.h"
#include "debug_utils.h" #include "debug_utils.h"
#include "memory_tracker-inl.h"
#include "node_contextify.h" #include "node_contextify.h"
#include "node_buffer.h" #include "node_buffer.h"
#include "node_errors.h" #include "node_errors.h"

View File

@ -1,4 +1,5 @@
#include "aliased_buffer.h" #include "aliased_buffer.h"
#include "memory_tracker-inl.h"
#include "node_internals.h" #include "node_internals.h"
#include "node_perf.h" #include "node_perf.h"
#include "node_buffer.h" #include "node_buffer.h"

View File

@ -19,6 +19,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
#include "memory_tracker-inl.h"
#include "node_stat_watcher.h" #include "node_stat_watcher.h"
#include "async_wrap-inl.h" #include "async_wrap-inl.h"
#include "env.h" #include "env.h"

View File

@ -1,5 +1,6 @@
#include "base_object-inl.h" #include "base_object-inl.h"
#include "env.h" #include "env.h"
#include "memory_tracker-inl.h"
#include "node.h" #include "node.h"
#include "node_internals.h" #include "node_internals.h"
#include "node_v8_platform-inl.h" #include "node_v8_platform-inl.h"

View File

@ -1,5 +1,6 @@
#include "node_worker.h" #include "node_worker.h"
#include "debug_utils.h" #include "debug_utils.h"
#include "memory_tracker-inl.h"
#include "node_errors.h" #include "node_errors.h"
#include "node_buffer.h" #include "node_buffer.h"
#include "node_options-inl.h" #include "node_options-inl.h"

View File

@ -19,6 +19,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
#include "memory_tracker-inl.h"
#include "node.h" #include "node.h"
#include "node_buffer.h" #include "node_buffer.h"

View File

@ -22,6 +22,7 @@
#include "tls_wrap.h" #include "tls_wrap.h"
#include "async_wrap-inl.h" #include "async_wrap-inl.h"
#include "debug_utils.h" #include "debug_utils.h"
#include "memory_tracker-inl.h"
#include "node_buffer.h" // Buffer #include "node_buffer.h" // Buffer
#include "node_crypto.h" // SecureContext #include "node_crypto.h" // SecureContext
#include "node_crypto_bio.h" // NodeBIO #include "node_crypto_bio.h" // NodeBIO