1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove common.PORT from multiple tests

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/12451
Ref: https://github.com/nodejs/node/issues/12376
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Tarun Batra 2017-04-17 02:21:48 +05:30 committed by James M Snell
parent 3cf88a45e8
commit 2e5188de92
7 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-cluster-master-error.js
View File

@ -31,7 +31,7 @@ if (cluster.isWorker) {
const http = require('http'); const http = require('http');
http.Server(() => { http.Server(() => {
}).listen(common.PORT, '127.0.0.1'); }).listen(0, '127.0.0.1');
} else if (process.argv[2] === 'cluster') { } else if (process.argv[2] === 'cluster') {

2
test/parallel/test-cluster-master-kill.js
View File

@ -28,7 +28,7 @@ if (cluster.isWorker) {
// keep the worker alive // keep the worker alive
const http = require('http'); const http = require('http');
http.Server().listen(common.PORT, '127.0.0.1'); http.Server().listen(0, '127.0.0.1');
} else if (process.argv[2] === 'cluster') { } else if (process.argv[2] === 'cluster') {

4
test/parallel/test-cluster-net-send.js
View File

@ -67,8 +67,8 @@ if (process.argv[2] !== 'child') {
socketConnected(); socketConnected();
}); });
server.listen(common.PORT, function() { server.listen(0, function() {
socket = net.connect(common.PORT, '127.0.0.1', socketConnected); socket = net.connect(server.address().port, '127.0.0.1', socketConnected);
}); });
process.on('disconnect', function() { process.on('disconnect', function() {

2
test/parallel/test-cluster-rr-domain-listen.js
View File

@ -32,7 +32,7 @@ if (cluster.isWorker) {
d.run(common.noop); d.run(common.noop);
const http = require('http'); const http = require('http');
http.Server(common.noop).listen(common.PORT, '127.0.0.1'); http.Server(common.noop).listen(0, '127.0.0.1');
} else if (cluster.isMaster) { } else if (cluster.isMaster) {

2
test/parallel/test-cluster-rr-ref.js
View File

@ -10,7 +10,7 @@ if (cluster.isMaster) {
}); });
} else { } else {
const server = net.createServer(common.mustNotCall()); const server = net.createServer(common.mustNotCall());
server.listen(common.PORT, function() { server.listen(0, function() {
server.unref(); server.unref();
server.ref(); server.ref();
server.close(function() { server.close(function() {

8
test/parallel/test-cluster-shared-leak.js
View File

@ -13,10 +13,10 @@ if (cluster.isMaster) {
let conn, worker2; let conn, worker2;
const worker1 = cluster.fork(); const worker1 = cluster.fork();
worker1.on('message', common.mustCall(function() { worker1.on('listening', common.mustCall(function(address) {
worker2 = cluster.fork(); worker2 = cluster.fork();
worker2.on('online', function() { worker2.on('online', function() {
conn = net.connect(common.PORT, common.mustCall(function() { conn = net.connect(address.port, common.mustCall(function() {
worker1.disconnect(); worker1.disconnect();
worker2.disconnect(); worker2.disconnect();
})); }));
@ -48,6 +48,4 @@ const server = net.createServer(function(c) {
c.end('bye'); c.end('bye');
}); });
server.listen(common.PORT, function() { server.listen(0);
process.send('listening');
});

4
test/parallel/test-cluster-worker-no-exit.js
View File

@ -20,7 +20,7 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict'; 'use strict';
const common = require('../common'); require('../common');
const assert = require('assert'); const assert = require('assert');
const cluster = require('cluster'); const cluster = require('cluster');
const net = require('net'); const net = require('net');
@ -55,7 +55,7 @@ if (cluster.isMaster) {
success = true; success = true;
}); });
}).listen(common.PORT, function() { }).listen(0, function() {
const port = this.address().port; const port = this.address().port;
worker = cluster.fork() worker = cluster.fork()