1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix weird string error

Browse Source 
Previously getting this error when running `tap2junit` (what parses our
`.tap` files in CI):

```
Traceback (most recent call last):
  File "/usr/local/bin/tap2junit", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main
    result.to_file(args.output, [result], prettyprint=False)
  File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file
    test_suites, prettyprint=prettyprint, encoding=encoding)
  File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string
    ts_xml = ts.build_xml_doc(encoding=encoding)
  File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc
    attrs['message'] = decode(case.skipped_message, encoding)
  File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode
    ret = unicode(var)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128)
```

PR-URL: https://github.com/nodejs/node/pull/21793
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Jon Moss 2018-07-13 10:45:42 -04:00 committed by Anna Henningsen
parent 57e301539b
commit 2d950701a1
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-stdio-pipe-access.js
View File

@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
if (!common.isMainThread)
common.skip('Workers don’t have process-like stdio');
common.skip("Workers don't have process-like stdio");
// Test if Node handles acessing process.stdin if it is a redirected
// pipe without deadlocking

2
test/parallel/test-stdio-pipe-redirect.js
View File

@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
if (!common.isMainThread)
common.skip('Workers don’t have process-like stdio');
common.skip("Workers don't have process-like stdio");
// Test if Node handles redirecting one child process stdout to another
// process stdin without crashing.