1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: reset process.versions during pre-execution

Browse Source 
Reset `process.versions` during pre-execution so that it reflects
the versions at run-time rather than when the snapshot was taken.

PR-URL: https://github.com/nodejs/node/pull/53444
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This commit is contained in:
Richard Lau 2024-06-20 19:07:19 +01:00 committed by GitHub
parent 167ef1a621
commit 2cb3504064
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 37 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
src/node_process_object.cc
View File

@ -77,34 +77,9 @@ static void GetParentProcessId(Local<Name> property,
info.GetReturnValue().Set(uv_os_getppid()); info.GetReturnValue().Set(uv_os_getppid());
} }
MaybeLocal<Object> CreateProcessObject(Realm* realm) { static void SetVersions(Isolate* isolate, Local<Object> versions) {
Isolate* isolate = realm->isolate(); Local<Context> context = isolate->GetCurrentContext();
EscapableHandleScope scope(isolate);
Local<Context> context = realm->context();
Local<FunctionTemplate> process_template = FunctionTemplate::New(isolate);
process_template->SetClassName(realm->env()->process_string());
Local<Function> process_ctor;
Local<Object> process;
if (!process_template->GetFunction(context).ToLocal(&process_ctor) ||
!process_ctor->NewInstance(context).ToLocal(&process)) {
return MaybeLocal<Object>();
}
// process[exit_info_private_symbol]
if (process
->SetPrivate(context,
realm->env()->exit_info_private_symbol(),
realm->env()->exit_info().GetJSArray())
.IsNothing()) {
return {};
}
// process.version
READONLY_PROPERTY(
process, "version", FIXED_ONE_BYTE_STRING(isolate, NODE_VERSION));
Local<Object> versions = Object::New(isolate);
// Node.js version is always on the top // Node.js version is always on the top
READONLY_STRING_PROPERTY( READONLY_STRING_PROPERTY(
versions, "node", per_process::metadata.versions.node); versions, "node", per_process::metadata.versions.node);
@ -137,8 +112,38 @@ MaybeLocal<Object> CreateProcessObject(Realm* realm) {
v8::ReadOnly) v8::ReadOnly)
.Check(); .Check();
} }
}
MaybeLocal<Object> CreateProcessObject(Realm* realm) {
Isolate* isolate = realm->isolate();
EscapableHandleScope scope(isolate);
Local<Context> context = realm->context();
Local<FunctionTemplate> process_template = FunctionTemplate::New(isolate);
process_template->SetClassName(realm->env()->process_string());
Local<Function> process_ctor;
Local<Object> process;
if (!process_template->GetFunction(context).ToLocal(&process_ctor) ||
!process_ctor->NewInstance(context).ToLocal(&process)) {
return MaybeLocal<Object>();
}
// process[exit_info_private_symbol]
if (process
->SetPrivate(context,
realm->env()->exit_info_private_symbol(),
realm->env()->exit_info().GetJSArray())
.IsNothing()) {
return {};
}
// process.version
READONLY_PROPERTY(
process, "version", FIXED_ONE_BYTE_STRING(isolate, NODE_VERSION));
// process.versions // process.versions
Local<Object> versions = Object::New(isolate);
SetVersions(isolate, versions);
READONLY_PROPERTY(process, "versions", versions); READONLY_PROPERTY(process, "versions", versions);
// process.arch // process.arch
@ -248,6 +253,11 @@ void PatchProcessObject(const FunctionCallbackInfo<Value>& args) {
None, None,
SideEffectType::kHasNoSideEffect) SideEffectType::kHasNoSideEffect)
.FromJust()); .FromJust());
// process.versions
Local<Object> versions = Object::New(isolate);
SetVersions(isolate, versions);
READONLY_PROPERTY(process, "versions", versions);
} }
void RegisterProcessExternalReferences(ExternalReferenceRegistry* registry) { void RegisterProcessExternalReferences(ExternalReferenceRegistry* registry) {