src: use "constants" string instead of creating new one

Using the same "constants" string in c++.

PR-URL: https://github.com/nodejs/node/pull/23894
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This commit is contained in:
Ouyang Yadong 2018-10-25 14:05:41 +08:00 committed by Refael Ackermann
parent bd8c107894
commit 2cab511d95
3 changed files with 3 additions and 3 deletions

View File

@ -3111,7 +3111,7 @@ HTTP_STATUS_CODES(V)
env->SetMethod(target, "packSettings", PackSettings);
target->Set(context,
FIXED_ONE_BYTE_STRING(isolate, "constants"),
env->constants_string(),
constants).FromJust();
target->Set(context,
FIXED_ONE_BYTE_STRING(isolate, "nameForErrorCode"),

View File

@ -109,7 +109,7 @@ void PipeWrap::Initialize(Local<Object> target,
NODE_DEFINE_CONSTANT(constants, UV_READABLE);
NODE_DEFINE_CONSTANT(constants, UV_WRITABLE);
target->Set(context,
FIXED_ONE_BYTE_STRING(env->isolate(), "constants"),
env->constants_string(),
constants).FromJust();
}

View File

@ -124,7 +124,7 @@ void TCPWrap::Initialize(Local<Object> target,
NODE_DEFINE_CONSTANT(constants, SOCKET);
NODE_DEFINE_CONSTANT(constants, SERVER);
target->Set(context,
FIXED_ONE_BYTE_STRING(env->isolate(), "constants"),
env->constants_string(),
constants).FromJust();
}