1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: check if _events is an own property

Browse Source 
Without this check it is possible to have the _events object shared
amongst instances.

Fixes #7157

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
Vladimir Kurchatkin 2014-04-04 02:11:56 +04:00 committed by Trevor Norris
parent c7f424e44b
commit 2c6b424829
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/events.js
View File

@ -49,7 +49,10 @@ EventEmitter.init = function() {
this.domain = domain.active; this.domain = domain.active;
} }
} }
this._events = this._events || {};
if (!this._events || this._events === Object.getPrototypeOf(this)._events)
this._events = {};
this._maxListeners = this._maxListeners || undefined; this._maxListeners = this._maxListeners || undefined;
}; };

14
test/simple/test-event-emitter-subclass.js
View File

@ -53,3 +53,17 @@ process.on('exit', function() {
assert.deepEqual(myee._events, {}); assert.deepEqual(myee._events, {});
console.log('ok'); console.log('ok');
}); });
function MyEE2() {
EventEmitter.call(this);
}
MyEE2.prototype = new EventEmitter();
var ee1 = new MyEE2();
var ee2 = new MyEE2();
ee1.on('x', function () {});
assert.equal(EventEmitter.listenerCount(ee2, 'x'), 0);